[GLUTEN-10933][VL] BroadcastExchange outputs cudf::table#11441
Merged
jinchengchenghh merged 4 commits intoapache:mainfrom Jan 28, 2026
Merged
[GLUTEN-10933][VL] BroadcastExchange outputs cudf::table#11441jinchengchenghh merged 4 commits intoapache:mainfrom
jinchengchenghh merged 4 commits intoapache:mainfrom
Conversation
jinchengchenghh
force-pushed
the
fix_bhj
branch
from
aee7e8f to
283922c
Compare
marin-ma
reviewed
Jan 28, 2026
| // Need to allocate null buffer. | ||
| if (returnBuffers[bufferIdx] == nullptr) { | ||
| std::shared_ptr<arrow::Buffer> buffer; | ||
| GLUTEN_ASSIGN_OR_THROW(buffer, arrow::AllocateResizableBuffer(bufferSizes[bufferIdx], pool)); |
Contributor
There was a problem hiding this comment.
Should it be arrow::bit_util::BytesForBits(bufferSizes[bufferIdx])？
Contributor
Author
There was a problem hiding this comment.
The bufferSizes is computed here, https://github.com/apache/incubator-gluten/pull/11441/changes#diff-ce18661fb719aacbaf297406b7d1dc8406164158b10644ce68b15cf51d94ea12R102, so it is bytes
jinchengchenghh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow up of #11090, broadcast table is usually a small table, so we don't serialize to cudf format in the first step, just convert it to cudf table, this might be expensive for string data type.
May optimize to serialize to cudf format and deserialize to cudf table as hash shuffle reader, copy the buffer to deserialize to cudf::table.
Test in local with TPCDS Q95.
Related issue: #10933